Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W10-4] Know-It-All #23

Open
wants to merge 1,244 commits into
base: master
Choose a base branch
from
Open

[W10-4] Know-It-All #23

wants to merge 1,244 commits into from

Conversation

afterdusk
Copy link

@kylase-learning
Copy link

Feedback (Week 7; v1.1)

Github Project Page

  • Update Project description
  • Update Link to Project Page

README

  • UI Mockup updated in project website
  • Make the project website look like a product home page (aka remove the top nav bar)
  • AB4 ackhowledgement
  • Travis badge updated to own fork's
  • Coveralls badge updated to own fork's

Project Page

  • Update to remove AB4 reference
  • Travis badge updated to own fork's
  • Coveralls badge updated to own fork's

About Us Page

  • Updated with photos
  • Roles and components assigned

UG/DG feedback will be provided to you in the documents.

cchj1995 pushed a commit to cchj1995/addressbook-level4 that referenced this pull request Mar 11, 2019
@kthSim
Merge pull request nus-cs2103-AY1819S2#23 from kthSim/docs
3a059c9 
Updated Project Docs
kylase-learning
kylase-learning reviewed Apr 8, 2019
View reviewed changes
README.adoc
*_Know-It-All_* is proud to present the following _awards_:

ifdef::env-github[]
image:award1.png[width="200"] {nbsp}{nbsp}{nbsp}{nbsp}{nbsp}{nbsp}{nbsp}{nbsp}{nbsp}{nbsp}image:award2.png[width="200"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm.... is this fake news? 😅

afterdusk and others added 21 commits April 12, 2019 02:46
@afterdusk
Update CSV test file names
35dc45d
@KerrynEer
Merge pull request #26 from cs2103-ay1819s2-w10-4/master
d28edfe 
Update UG, DG and PPP and check for valid folder names
@yichong96
rename PPP ascii doc
f8548f4
@yichong96
update PPP intro
ee62436
@afterdusk
Add data directory warning to QuickStart in UG
c9c3a3d
@KerrynEer
Replace previous saveLocation in status bar to currentStatus
66da2b7
@KerrynEer
Replace saveLocation with current status in comment
3b785bb
@afterdusk
Update ModelManagerTest and add AddFolderCommandTest
722ab6a
@KerrynEer
Add test command logic junit and integration test for an empty folder
02e7ce9
@KerrynEer
Add next command test for the case when there are no more cards in th…
c4cb517 
…e folder.
@KerrynEer
Fix set current tested Card test method name typo
925d3df
@KerrynEer
Correct mistake in set current tested card test method in ModelManager
aeea1bb
@dlqs
add test for sort command
40fe8eb
@dlqs
add comparator test
238f1d9
@dlqs
add test for end report
e52c589
@dlqs
fix checkstyle
c54fd83
@afterdusk
Update StorageManagerTest
767baad
@dlqs
add system test for report
82296ec
@afterdusk
Add EditFolderTest
fc996e3 
Also fixed bug with rename() method in CardFolder and performed minor updates to other tests
@afterdusk
Fix wrong invalid index message for EditFolderCommand
4efd27d
@afterdusk
Add DeleteFolderCommandTest
72e85eb
yichong96 and others added 30 commits April 15, 2019 22:03
@yichong96
update dev guide
c854c7e
@yichong96
modified glossary
1718f66
@KerrynEer
Bold all instances of Know-it-all in UG
8f3dcf2
@KerrynEer
Fix typo
ba663d6
@afterdusk
Make folder names case insensitive
4eab37a
@afterdusk
Merge remote-tracking branch 'upstream/master'
247a0cd
@mmdlow
Update glossary references in user guide
5d3b086
@afterdusk
Rename a variable in EditFolderCommand
8fc193d
@KerrynEer
Fix small typo in DG
b2da476
@mmdlow
Remove errors in command summary of user guide
f4284ff
@mmdlow
Fix minor error in dev guide
0a06b38
@mmdlow
Update PPP
e516442
@afterdusk
Fix checkstyle issues
0d5f97b
@mmdlow
Merge pull request #192 from yichong96/updateDocs
657e5a7 
Update docs
@KerrynEer
Revert "Bold all instances of Know-it-all in UG"
8fd9b84 
This reverts commit 8f3dcf2.
@mmdlow
Merge branch 'master' into dev
ae4cd4e
@mmdlow
Merge pull request #194 from mmdlow/dev
b324aa9 
Update docs
@afterdusk
Fix error in resetStates() of VersionedCardFolder
28be935
@KerrynEer
Merge remote-tracking branch 'upstream/master'
abfe19d 
# Conflicts:
#	docs/DeveloperGuide.adoc
@dlqs
Merge pull request #193 from afterdusk/master
70934a5 
Perform Bug Fixes
@dlqs
fix wrong size committed
e625176
@KerrynEer
Fix typo in link
461a3e3
@yichong96
Merge pull request #189 from KerrynEer/master
b266dc9 
Final updates to docs
@dlqs
fix div by zeo bug
e6df749
@dlqs
liang's aasserts
b9d9d05
@dlqs
Merge branch 'master' of github.com:cs2103-ay1819s2-w10-4/main into b…
7204221 
…ugfix
@dlqs
yc's changes
320445a
@dlqs
Merge pull request #195 from dlqs/bugfix
b01d09d 
Bugfix
@afterdusk
Remove PE-specific considerations for PPP
a816abf 
Also changed the default HTML font from Noto Serif to Roboto.
@afterdusk
Merge pull request #197 from afterdusk/master
9a6e705 
Remove PE-specific considerations for PPP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylase-learning kylase-learning kylase-learning left review comments

Assignees

@kylase-learning kylase-learning

Labels
V1.1-Reviewed W10-4 W10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@afterdusk @kylase-learning @nus-se-pr-bot @KerrynEer @yichong96 @dlqs @mmdlow